mirror of
https://github.com/deepseek-ai/deepseek-harness.git
synced 2026-08-29 04:26:38 +00:00
fix(cic): restore subscription-type gates and note table for split publish
Address the fresh review pass on PR #2798: - ci-workflow.spec.ts: restore the subscription-type assertions the rewrite had dropped (issue-lifecycle pull_request types omit ready_for_review and include review_requested; pull_request_review types == ['submitted']) alongside the new step-level gate checks, so the 'tests pin the subscribed events' gate holds. - 2026-08-10-npm-release-sequences note (en/zh/i18n): the three-sequence table's Workflow column now lists the pack and publish workflows for dsh/vendor, and line 114 no longer claims release.yml publishes (the dsh pack job packs the vendored family for verification; release-publish.yml repacks and publishes). Follow-up for the pack-job copy drift is filed as #2816.
This commit is contained in:
@@ -430,6 +430,14 @@ describe('Issue lifecycle workflow', () => {
|
||||
expect(lifecycle.on).toHaveProperty('pull_request')
|
||||
expect(lifecycle.on).toHaveProperty('pull_request_review')
|
||||
expect(lifecycleJob.if).toBeUndefined()
|
||||
// Keep the subscription-type gates: issue-lifecycle does not re-subscribe
|
||||
// ready_for_review (issue-policy owns that) and only reacts to submitted
|
||||
// review events.
|
||||
const lifecyclePullRequest = workflowEvent(lifecycle, 'pull_request')
|
||||
const lifecycleReview = workflowEvent(lifecycle, 'pull_request_review')
|
||||
expect(lifecyclePullRequest.types).not.toContain('ready_for_review')
|
||||
expect(lifecyclePullRequest.types).toContain('review_requested')
|
||||
expect(lifecycleReview.types).toEqual(['submitted'])
|
||||
const gated = "${{ github.event_name != 'pull_request_review' || github.event.review.state == 'changes_requested' }}"
|
||||
const steps = lifecycleJob.steps.filter(isRecord)
|
||||
const tokenStep = steps.find(s => s.name === 'Create project token')
|
||||
|
||||
Reference in New Issue
Block a user