mengzhx/deepseek-harness
1
0
Fork 0
mirror of https://github.com/deepseek-ai/deepseek-harness.git synced 2026-09-11 04:00:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(code-runtime-python): state the macOS killGroup behavior directly and complete the residual sentence

Browse Source 
The review flagged the change-narrative wording 'degrades to the pre-existing
behavior' (prohibited by docs/AGENTS.md) in four spots — README en/zh, the
readProcessStart JSDoc, and the test comment — and the incomplete :77 residual
sentence ('can still' with no verb complement). Reword the four to a direct
statement of current behavior (killGroup signals the pgid without the identity
re-check on macOS), complete the residual sentence with the actual consequence,
and re-record both pairings. Corpus-wide verify-translation-pairing passes 1029.
This commit is contained in:
Chinesezjc
2026-08-31 14:46:31 +08:00
committed by Tianyi Cui
parent e0d552fa86
commit 4c7811812d
8 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/code-runtime/code-runtime-python/tests/runtime.spec.ts
+3 -2
View File
@@ -408,8 +408,9 @@ describe('PythonCodeRuntime — process identity', () => {
// undefined and the guard is inert).
expect(readProcessStart(0)).toBeUndefined()
} else {
// Darwin has no /proc: the reader reports undefined, and `killGroup` then
// keeps its pre-existing behavior instead of paying a `ps` fork per signal.
// Darwin has no /proc: the reader reports undefined, and `killGroup`
// signals the pgid without the identity re-check instead of paying a `ps`
// fork per signal.
expect(own).toBeUndefined()
}
})