From 7214d0d9588fb0e6b9477dc063c530ecdcfc1c95 Mon Sep 17 00:00:00 2001 From: Chinesezjc Date: Fri, 21 Aug 2026 11:55:57 +0800 Subject: [PATCH] refactor(python): drop now-always-true build.if python-release.yml only triggers on workflow_dispatch, so build.if: github.event_name == 'workflow_dispatch' is always true and redundant; remove it (the exact event set is already pinned in the spec). Update the spec assertion accordingly. --- .github/workflows/python-release.yml | 1 - scripts/ci-workflow.spec.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/.github/workflows/python-release.yml b/.github/workflows/python-release.yml index d33ad71ba5..d888d17a8a 100644 --- a/.github/workflows/python-release.yml +++ b/.github/workflows/python-release.yml @@ -25,7 +25,6 @@ concurrency: jobs: build: name: Build four wheels - if: github.event_name == 'workflow_dispatch' uses: ./.github/workflows/build-exe-for-python-sdk.yml with: targets: node24-linux-x64,node24-linux-arm64,node24-macos-arm64 diff --git a/scripts/ci-workflow.spec.ts b/scripts/ci-workflow.spec.ts index b5497b0e9e..ed59846160 100644 --- a/scripts/ci-workflow.spec.ts +++ b/scripts/ci-workflow.spec.ts @@ -291,7 +291,6 @@ describe('Python release workflows', () => { if (!isRecord(workflow.on)) throw new TypeError('python-release workflow must define on') expect(Object.keys(workflow.on)).toEqual(['workflow_dispatch']) expect(build).toMatchObject({ - if: "github.event_name == 'workflow_dispatch'", uses: './.github/workflows/build-exe-for-python-sdk.yml', with: { targets: 'node24-linux-x64,node24-linux-arm64,node24-macos-arm64',