From ac2f00070e0ea80218b993c0768cecec7a8bc350 Mon Sep 17 00:00:00 2001 From: Chinesezjc Date: Tue, 25 Aug 2026 17:02:16 +0800 Subject: [PATCH] ci(windows): make windows-coverage temporarily non-blocking Other PRs are blocked by Windows ACP half-close tests timing out. Keep the coverage job running for signal, but remove it from all-checks-passed.needs until the Windows skip fix is validated. --- .github/workflows/ci.yml | 2 +- scripts/ci-workflow.spec.ts | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aa36a92dc8..b486e5df30 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -568,7 +568,7 @@ jobs: && github.event.pull_request.user.login != 'dependabot[bot]' && fromJSON('["self-hosted", "linux", "x64", "vm-backup"]') || 'ubuntu-latest' }} - needs: [node-24, node-24-coverage, node-24-consumers, node-compat, python-sdk, python-runtime, windows, windows-build, windows-coverage, windows-native-tests] + needs: [node-24, node-24-coverage, node-24-consumers, node-compat, python-sdk, python-runtime, windows, windows-build, windows-native-tests] if: always() && github.event_name == 'pull_request' steps: - name: Fail if any needed job did not succeed diff --git a/scripts/ci-workflow.spec.ts b/scripts/ci-workflow.spec.ts index e5aceb8e25..a4011ba06c 100644 --- a/scripts/ci-workflow.spec.ts +++ b/scripts/ci-workflow.spec.ts @@ -129,11 +129,12 @@ describe('CI workflow', () => { expect(serialWindows['runs-on']).toEqual(['self-hosted', 'dsh-win-ci', 'windows']) expect(serialWindows.name).toBe('serial / windows (self-hosted standby)') - // Aggregate: Wine and the three required split native jobs are needed; - // observational stays out of the verdict. + // Aggregate: Wine and the required split native jobs are needed; + // windows-coverage is temporarily non-blocking while Windows ACP + // half-close tests are stabilized; observational stays out too. expect(aggregate.needs).toContain('windows') expect(aggregate.needs).toContain('windows-build') - expect(aggregate.needs).toContain('windows-coverage') + expect(aggregate.needs).not.toContain('windows-coverage') expect(aggregate.needs).toContain('windows-native-tests') expect(aggregate.needs).not.toContain('windows-observational') expect(aggregate.needs).not.toContain('serial-windows')