From bbd899d47824f2a94e46ec1691c2f6fa71bb0130 Mon Sep 17 00:00:00 2001 From: Yif <877193178@qq.com> Date: Tue, 8 Sep 2026 01:16:56 +0800 Subject: [PATCH] fix(client): count IconGaugeOutline16 in the icon-set pin; keep the hero headline text addressable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The icon-set spec still pinned 74 exports after IconGaugeOutline16 landed (a hand-drawn product glyph — the set is now eight of those). Moving the preview badge inside the hero title group had merged the headline into one text node with the badge, which broke exact text lookup (hmr-live e2e); the headline gets its own span again. --- .../client/ui-conversation/src/client/skeleton/EmptyHero.tsx | 3 ++- packages/client/ui-primitives/tests/icons.client.spec.tsx | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/client/ui-conversation/src/client/skeleton/EmptyHero.tsx b/packages/client/ui-conversation/src/client/skeleton/EmptyHero.tsx index e0a7bcb924..9ac7ae573b 100644 --- a/packages/client/ui-conversation/src/client/skeleton/EmptyHero.tsx +++ b/packages/client/ui-conversation/src/client/skeleton/EmptyHero.tsx @@ -150,7 +150,8 @@ export function HeroShell({ t, renderSlot, children }: HeroShellProps) { })} - {t('hero.headline')} + {/* Own element: keeps the headline text addressable apart from the badge. */} + {t('hero.headline')} {t('hero.preview')} diff --git a/packages/client/ui-primitives/tests/icons.client.spec.tsx b/packages/client/ui-primitives/tests/icons.client.spec.tsx index e29bb2ce14..1b9a9c7773 100644 --- a/packages/client/ui-primitives/tests/icons.client.spec.tsx +++ b/packages/client/ui-primitives/tests/icons.client.spec.tsx @@ -17,8 +17,8 @@ const icons = Object.fromEntries( const iconNames = Object.keys(icons) describe('ic_ds_ icon set', () => { - it('exports the full icon set (46 deepsuite + 21 figma extracts + seven product glyphs outside those sets)', () => { - expect(iconNames.length).toBe(74) + it('exports the full icon set (46 deepsuite + 21 figma extracts + eight product glyphs outside those sets)', () => { + expect(iconNames.length).toBe(75) }) it.each(iconNames)('%s renders an svg with currentColor fills and no hardcoded palette', (name) => {