mirror of
https://github.com/deepseek-ai/deepseek-harness.git
synced 2026-09-09 04:02:35 +00:00
Yichen Jiang
2795940323
Review found the package's prose still describing a plugin that an earlier revision removed, and three factual slips about behavior. - policy.ts, install.ts, install.spec.ts, and the Agent Note named a `Config` surface, a `cordis.yml` source, a mountable plugin, and a `plugin.spec.ts` that no longer exist; each now describes the environment-only resolution the launcher actually runs. - `NO_PROXY=example.com` bypasses `api.example.com` as well — the matcher accepts the host and every subdomain under it, and a leading `.` or `*.` means the same thing. The guide, README, and JSDoc claimed a bare entry matched only the exact host, which would let a reader believe a subdomain was proxied when it went direct. - A rejection diagnostic names the variable and never its value, so no username is shown; the guide said the username was shown with the rest masked. The README's source map claimed a "redaction" step that does not exist. - The `node:https` worker placeholder was added for a `node:http` agent factory this PR later removed; nothing imports `node:https` now, so the stub, its VFS mapping, and its test return to their state on master.