mirror of
https://github.com/deepseek-ai/deepseek-harness.git
synced 2026-09-14 04:01:35 +00:00
Yichen Jiang
daaede29a5
The turn-error Definition suppressed its node permanently once the owning turn carried any llm/retry event — a rule from the retired model where a retry opened a new numbered turn. Retries now run inside the failing turn, so the suppression hid exactly the exhausted terminal failure it existed to defer to: spending every transient retry left the conversation with a neutral collapsed retry row and no error row at all. Delete the suppression: turn-error matches only turn/start and error-reason turn/end, and renders whenever its turn recorded a terminal error; the settled retry chain renders beside it through the separate model-retry node. The Definition suite now asserts the exhausted-retry error node in full history, tail-only windows, and after prepending the chain, and a new keyless live e2e scenario exhausts a scenario-owned two-retry policy and pins the terminal error row beside the settled retry row (the scaffold gains replayRetryPolicy so exhaustion runs in milliseconds). Both stale notes are corrected to the same-turn retry reality, and the new bug-fix note owns the removal rationale.