mirror of
https://github.com/deepseek-ai/deepseek-harness.git
synced 2026-09-11 04:00:38 +00:00
Chinesezjc
a4d4404708
A settled top-level `read_image` call printed its raw attachment object as
literal text in the tool card — `{"type":"image","attachment":{…}}` —
instead of the image, because no presentation metadata told a client card
how to present the reference and the tool-card layer had no image concept.
Host: `read_image` declares an `output.presentationMeta` persisting
`{ path }` only. The attachment reference deliberately lives in the
settled result content — the single record a `tools/post-execute`
replacement rewrites — not in `meta`; the id is opaque and
provider-owned, checked for existence only.
Client: `imageCardModel` derives the card from the call head, the meta
path, the result's own image block, and a shape-matched envelope. ToolRow
gains an `image` card slot; the `read_image` toolview declares the
Tool-owned `tool.call.images` slot as its child and dispatches the
gallery through it. ui-chat down-threads the session-authorized loader
(`ChatNodeOwnerProps.loadImage`), so the tool layer supplies only derived
references plus the loader and never imports an attachment
implementation; ui-attachment fills the slot with its message gallery
renderer. The card keeps the envelope text below the gallery for the
no-attachment-plugin deployment. An image-bearing tool registers a keyed
toolview; the generic fallback keeps its flattened text. `read_image`
joins the read variant with its own locale title key; both rows share
`read-family-row.tsx`.
Verification: `read-image.spec.ts` (metadata projection, envelope by
shape, reference narrowing, real-execution round trip, rejection
branches incl. non-digest ids), `image-card.client.spec.tsx` (derivation,
row render site dispatching the slot, keyed registration with the
child-slot declaration, empty-slot fallbacks, media-type enum), keyless
snapshots (`read-image-gif` added; read-image/-dimension/-reencode
updated to the `{path}` meta), five injected-defect negative controls,
and a demo GIF recorded from this PR's head through the official
image-capable model.
59 lines
2.2 KiB
TypeScript
59 lines
2.2 KiB
TypeScript
import { Context } from '@deepseek-ai/cordis'
|
|
import { describe, expect, it } from 'vitest'
|
|
import { SlotRegistry } from '@deepseek-ai/dsh-client-ui-renderer/client'
|
|
import { apply as applyHost } from '../src/index.ts'
|
|
import { apply, inject } from '../src/client/index.ts'
|
|
import { ComposerAttachments } from '../src/client/ComposerAttachments.tsx'
|
|
import { MessageImages } from '../src/client/MessageImages.tsx'
|
|
|
|
async function bench() {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SlotRegistry).await()
|
|
ctx.slots.register({
|
|
name: 'root',
|
|
children: {
|
|
'conversation.input.attachments': { kind: 'single', scope: 'session-maybe' },
|
|
'conversation.message.images': { kind: 'single', scope: 'session' },
|
|
'conversation.trajectory.images': { kind: 'single', scope: 'session' },
|
|
'tool.call.images': { kind: 'single', scope: 'session' },
|
|
},
|
|
} as never, () => null)
|
|
const fiber = ctx.plugin({ inject: [...inject], apply })
|
|
await fiber.await()
|
|
return { ctx, fiber }
|
|
}
|
|
|
|
describe('attachment plugin', () => {
|
|
it('keeps the host half empty', () => {
|
|
expect(() => { applyHost() }).not.toThrow()
|
|
})
|
|
|
|
it('registers all entries and removes them with the plugin fiber', async () => {
|
|
const { ctx, fiber } = await bench()
|
|
expect(inject).toEqual(['slots'])
|
|
expect(ctx.slots.entries('conversation.input.attachments')).toMatchObject([{
|
|
locale: 'conversation',
|
|
component: ComposerAttachments,
|
|
}])
|
|
expect(ctx.slots.entries('conversation.message.images')).toMatchObject([{
|
|
locale: 'conversation',
|
|
component: MessageImages,
|
|
}])
|
|
expect(ctx.slots.entries('conversation.trajectory.images')).toMatchObject([{
|
|
locale: 'conversation',
|
|
component: MessageImages,
|
|
}])
|
|
expect(ctx.slots.entries('tool.call.images')).toMatchObject([{
|
|
locale: 'conversation',
|
|
component: MessageImages,
|
|
}])
|
|
|
|
await fiber.dispose()
|
|
|
|
expect(ctx.slots.entries('conversation.input.attachments')).toHaveLength(0)
|
|
expect(ctx.slots.entries('conversation.message.images')).toHaveLength(0)
|
|
expect(ctx.slots.entries('conversation.trajectory.images')).toHaveLength(0)
|
|
expect(ctx.slots.entries('tool.call.images')).toHaveLength(0)
|
|
})
|
|
})
|