From 2e5ad9d28bd6caf9e9765caccfd516059da3cf57 Mon Sep 17 00:00:00 2001 From: KaifAhmad1 Date: Wed, 18 Mar 2026 00:38:44 +0530 Subject: [PATCH] fix: address Qodo review issues in CI workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Replace '*.md' with '**/*.md' in paths-ignore across ci.yml, benchmark.yml, and security-scan.yml — '*.md' only matches root-level markdown; '**/*.md' covers all subdirectories (cookbook/, docs/, etc.) - Add cache: 'pip' to setup-python in ci.yml to avoid re-downloading heavy packages (torch, spacy, faiss) on every run - Update security-scan PR comment text to accurately reflect that it skips doc/markdown-only PRs, not "every PR" Co-Authored-By: Claude Sonnet 4.6 --- .github/workflows/benchmark.yml | 2 +- .github/workflows/ci.yml | 5 +++-- .github/workflows/security-scan.yml | 6 +++--- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 1accab99..301f8776 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -7,7 +7,7 @@ on: - 'docs/**' - 'mkdocs.yml' - 'requirements-docs.txt' - - '*.md' + - '**/*.md' workflow_dispatch: jobs: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac0a4ff8..a4d268d4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,14 +7,14 @@ on: - 'docs/**' - 'mkdocs.yml' - 'requirements-docs.txt' - - '*.md' + - '**/*.md' pull_request: branches: [main] paths-ignore: - 'docs/**' - 'mkdocs.yml' - 'requirements-docs.txt' - - '*.md' + - '**/*.md' jobs: build: @@ -24,6 +24,7 @@ jobs: - uses: actions/setup-python@v5 with: python-version: '3.11' + cache: 'pip' - run: pip install build - run: python -m build - run: pip install -e ".[dev]" diff --git a/.github/workflows/security-scan.yml b/.github/workflows/security-scan.yml index 3e117393..e4581e6e 100644 --- a/.github/workflows/security-scan.yml +++ b/.github/workflows/security-scan.yml @@ -9,14 +9,14 @@ on: - 'docs/**' - 'mkdocs.yml' - 'requirements-docs.txt' - - '*.md' + - '**/*.md' pull_request: branches: [main] paths-ignore: - 'docs/**' - 'mkdocs.yml' - 'requirements-docs.txt' - - '*.md' + - '**/*.md' jobs: security-scan: @@ -168,7 +168,7 @@ jobs: } // Create summary comment - const comment = `# šŸ”’ Security Scan Results\\n\\n${safetyResults}\\n\\n${banditResults}\\n\\n${semgrepResults}\\n\\n---\\n\\n*This security scan runs automatically on every PR and bi-weekly.*\\n\\nšŸ“Š **Security Policy**: CI fails on vulnerabilities and HIGH severity issues.`; + const comment = `# šŸ”’ Security Scan Results\\n\\n${safetyResults}\\n\\n${banditResults}\\n\\n${semgrepResults}\\n\\n---\\n\\n*This security scan runs automatically on source-code PRs and bi-weekly (skipped for doc/markdown-only changes).*\\n\\nšŸ“Š **Security Policy**: CI fails on vulnerabilities and HIGH severity issues.`; // Post comment with error handling try {