From 8beca572387de6e5fef5b4d6815f537af3327169 Mon Sep 17 00:00:00 2001 From: KaifAhmad1 Date: Sat, 25 Jul 2026 16:59:26 +0530 Subject: [PATCH] fix: wrap checkov:skip comment to respect yamllint's 120-char line-length limit The single-line checkov:skip=CKV_K8S_21 comment added in ed44260 was 286 characters, exceeding the repo's yamllint line-length rule (max 120, .pre-commit-config.yaml). Split into three short comment lines: the skip directive itself, then the rationale, in service.yaml, deployment.yaml, and configmap.yaml. --- deploy/helm/knowledge-explorer/templates/configmap.yaml | 4 +++- deploy/helm/knowledge-explorer/templates/deployment.yaml | 4 +++- deploy/helm/knowledge-explorer/templates/service.yaml | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/deploy/helm/knowledge-explorer/templates/configmap.yaml b/deploy/helm/knowledge-explorer/templates/configmap.yaml index 2b53173f..33dc2d33 100644 --- a/deploy/helm/knowledge-explorer/templates/configmap.yaml +++ b/deploy/helm/knowledge-explorer/templates/configmap.yaml @@ -1,4 +1,6 @@ -# checkov:skip=CKV_K8S_21:namespace is set to .Release.Namespace below, supplied at install time via `helm install -n `; Checkov's helm-chart renderer runs without a namespace override and always resolves this to "default", which is a scanner artifact, not the deployed value +# checkov:skip=CKV_K8S_21: namespace is set via .Release.Namespace, bound only at helm install/template time +# Checkov's helm renderer runs without a namespace override, so this always resolves to "default" here — +# a scanner artifact, not the deployed value; see .checkov.yaml apiVersion: v1 kind: ConfigMap metadata: diff --git a/deploy/helm/knowledge-explorer/templates/deployment.yaml b/deploy/helm/knowledge-explorer/templates/deployment.yaml index f14bbefa..110404f0 100644 --- a/deploy/helm/knowledge-explorer/templates/deployment.yaml +++ b/deploy/helm/knowledge-explorer/templates/deployment.yaml @@ -1,4 +1,6 @@ -# checkov:skip=CKV_K8S_21:namespace is set to .Release.Namespace below, supplied at install time via `helm install -n `; Checkov's helm-chart renderer runs without a namespace override and always resolves this to "default", which is a scanner artifact, not the deployed value +# checkov:skip=CKV_K8S_21: namespace is set via .Release.Namespace, bound only at helm install/template time +# Checkov's helm renderer runs without a namespace override, so this always resolves to "default" here — +# a scanner artifact, not the deployed value; see .checkov.yaml apiVersion: apps/v1 kind: Deployment metadata: diff --git a/deploy/helm/knowledge-explorer/templates/service.yaml b/deploy/helm/knowledge-explorer/templates/service.yaml index bee01cd4..60765841 100644 --- a/deploy/helm/knowledge-explorer/templates/service.yaml +++ b/deploy/helm/knowledge-explorer/templates/service.yaml @@ -1,4 +1,6 @@ -# checkov:skip=CKV_K8S_21:namespace is set to .Release.Namespace below, supplied at install time via `helm install -n `; Checkov's helm-chart renderer runs without a namespace override and always resolves this to "default", which is a scanner artifact, not the deployed value +# checkov:skip=CKV_K8S_21: namespace is set via .Release.Namespace, bound only at helm install/template time +# Checkov's helm renderer runs without a namespace override, so this always resolves to "default" here — +# a scanner artifact, not the deployed value; see .checkov.yaml apiVersion: v1 kind: Service metadata: