mirror of
https://github.com/semantica-agi/semantica.git
synced 2026-08-29 04:26:20 +00:00
fix: address review feedback on Databricks/Snowflake docs (PR #808)
- README: get_table_lineage() takes table_name first, then catalog/schema keyword args — the example had them in the wrong order, which would have queried lineage for the wrong fully-qualified table when copy-pasted. - modules.md: the ingest example used DatabricksIngestor without importing it, causing a NameError if copy-pasted as-is. - guides/ingest.md: corrected the claim that Databricks/Snowflake ingestors return "the same shape as DBIngestor" — DBIngestor.execute_query() returns a raw List[Dict] with no wrapper, unlike DatabricksData/SnowflakeData.
This commit is contained in:
@@ -301,7 +301,7 @@ for bundle in stix_xml_files:
|
||||
|
||||
## Source 6 — Enterprise Data Platforms (Databricks & Snowflake)
|
||||
|
||||
`DatabricksIngestor` and `SnowflakeIngestor` return the same shape as `DBIngestor` — a typed object (`DatabricksData` / `SnowflakeData`) whose `.data` field is `List[Dict]`, one dict per row. The same "transform to text, then store" pattern from Source 3 applies: pull only the tables and columns you need with a targeted query, then build a sentence per record before handing it to `AgentContext.store()`.
|
||||
`DatabricksIngestor` and `SnowflakeIngestor` return wrapper objects (`DatabricksData` / `SnowflakeData`) whose `.data` field is `List[Dict]` — the same list-of-dicts row shape that `DBIngestor.execute_query()` returns directly, without a wrapper. The same "transform to text, then store" pattern from Source 3 applies: pull only the tables and columns you need with a targeted query, then build a sentence per record before handing it to `AgentContext.store()`.
|
||||
|
||||
```python
|
||||
from semantica.ingest import DatabricksIngestor
|
||||
|
||||
+1
-1
@@ -31,7 +31,7 @@ Semantica is organized into **27 modules** across six logical layers. Each modul
|
||||
Loads data from files, web, databases, and streams into a unified `SourceDocument` format.
|
||||
|
||||
```python
|
||||
from semantica.ingest import FileIngestor, WebIngestor, ParquetIngestor, XMLIngestor
|
||||
from semantica.ingest import FileIngestor, WebIngestor, ParquetIngestor, XMLIngestor, DatabricksIngestor
|
||||
|
||||
# Files: PDF, DOCX, CSV, Excel, PPTX, JSON, HTML, archives
|
||||
ingestor = FileIngestor()
|
||||
|
||||
Reference in New Issue
Block a user