mirror of
https://github.com/semantica-agi/semantica.git
synced 2026-09-10 04:00:35 +00:00
Addresses real findings from the automated review on #824: - The script previously only matched uses: lines that already contained a 40-hex SHA, so a newly added mutable-tag action (e.g. some/action@v1) would never be scanned at all and the check would pass silently. It now matches every uses: line and hard-fails on any ref that isn't a full commit SHA. - A tag that fails to resolve via the GitHub API (rate limit, deleted tag) previously only logged a warning and continued; that's now a hard failure too, since an unverifiable pin is exactly the failure mode this check exists to catch. - verify-action-pins.yml only triggered on .github/workflows/** changes, so an edit to the verifier script itself wouldn't run the check that verifies it. Added the script path to both trigger filters. The reviewer's claim that slash-containing tag comments (release/v1) break the API lookup did not reproduce - tested directly against pypa/gh-action-pypi-publish@release/v1 and GitHub's commits API resolves multi-segment refs natively - so no change was needed there. Verified with a synthetic test workflow containing a mutable-tag action, a correctly-pinned SHA, and a deliberately mismatched SHA: the updated script now catches the first and third cases and passes the second. Also re-ran against the real workflow tree (40/40 pins still verify clean).