3 people bd41a5a24f fix(vector-store): prevent in-memory vector ID reuse (#1546) ...

* fix(vector-store): prevent in-memory vector id reuse

* fix(vector-store): synchronize in-memory mutations

* fix(vector-store): clarify no-silent-overwrite guarantee for in-memory ID generation

The while-loop in store_vectors() already prevents any generated candidate
from landing on a live key: it breaks only when the candidate is absent
from both pre_existing (the live store at lock-entry) and within_batch
(IDs chosen earlier in the same call).

This commit:
- Renames 'existing' to 'pre_existing' and introduces 'within_batch' to
  make the two-level de-dupe explicit and self-documenting.
- Tightens the break condition to 'not in pre_existing and not in
  within_batch' so within-batch duplicates are also guarded.
- Adds test_auto_generated_id_never_silently_overwrites_live_vector:
  stores 5, deletes 3, stores 2 more and asserts none of the new IDs
  land on a surviving vec_N.
- Adds test_collision_detection_no_silent_overwrite_even_with_corrupted_counter:
  rewinds _next_id to 0 with live vectors present and proves the loop
  finds a free slot without overwriting either existing vector or its
  metadata — the no-silent-overwrite invariant holds even under counter
  corruption.

The skip-over-occupied-key behaviour for caller-inserted vec_N IDs is
intentional and preserved (test_counter_skips_explicit_vec_n_ids), matching
FAISSStore's identical pattern.

Closes reviewer finding: 'Vector collisions do not fail writes'.

* fix(vector-store): protect concurrent in-memory access

---------

Co-authored-by: Sameer Kadam <sameerkadam@Mac.lan>
Co-authored-by: Zohaib Hassnain <109234410+ZohaibHassan16@users.noreply.github.com>

2026-09-09 17:02:27 +05:30

..

test_backend_facade_contract.py

Fix/parse and qdrant vector store (#1508)

2026-09-08 15:47:05 +05:30

test_backend_metadata_filtering.py

fix: address code review findings in backend metadata filtering

2026-08-12 12:46:23 +05:30

test_backward_compatibility.py

fix(vector-store): standardize search_vectors output schema

2026-08-07 19:39:14 +05:30

test_decision_embedding_pipeline.py

fix: address code review findings in backend metadata filtering

2026-08-12 12:46:23 +05:30

test_end_to_end_decision_tracking.py

fix: resolve all failing tests for 0.3.0-alpha and Unreleased features

2026-03-06 02:54:09 +05:30

test_faiss_delete_vectors.py

feat(faiss): add native vector deletion support (#1507)

2026-09-07 17:39:17 +05:00

test_faiss_index.py

fix(vector_store): persist vector_ids and metadata across FAISS index save/load (#1272) (#1314)

2026-09-02 13:44:42 +05:00

test_hybrid_similarity.py

[FEATURE] Enhanced Vector Store for Decision Tracking #293

2026-02-11 19:02:33 +05:30

test_inmemory_id_reuse.py

fix(vector-store): prevent in-memory vector ID reuse (#1546)

2026-09-09 17:02:27 +05:30

test_kg_integration.py

fix: resolve all failing tests for 0.3.0-alpha and Unreleased features

2026-03-06 02:54:09 +05:30

test_milvus_delete_vectors.py

feat(milvus): add delete_vectors to MilvusStore (#1391)

2026-09-07 12:02:19 +05:30

test_milvus_get_collection.py

fix(vector-store): validate collection schema in MilvusStore.get_collection (#1344)

2026-09-02 00:58:26 +05:00

test_milvus_store.py

docs(vector_store): note the milvus schema assumption

2026-09-01 23:09:53 +05:00

test_performance_benchmarks.py

[FEATURE] Enhanced Vector Store for Decision Tracking #293

2026-02-11 19:02:33 +05:30

test_pgvector_store.py

feat(vector_store): add scan_vectors enumeration and wire up store mi… (#1264)

2026-08-30 17:31:57 +05:30

test_pinecone_removal.py

fix: Apply code review fixes for Pinecone integration (PR #220)

2026-01-26 20:49:29 +05:30

test_pinecone_store.py

fix(vector_store): don't short-circuit pinecone iter_all() on an empty page

2026-09-02 19:54:24 +05:30

test_qdrant_collection_search.py

fix: handle Qdrant vector count compatibility

2026-09-08 00:54:16 +05:30

test_qdrant_facade_writes.py

Fix/parse and qdrant vector store (#1508)

2026-09-08 15:47:05 +05:30

test_qdrant_store.py

fix(vector_store): sync qdrant iter_all() with #1316's stall-guard fix

2026-09-02 17:39:42 +05:30

test_search_result_schema.py

Fix/parse and qdrant vector store (#1508)

2026-09-08 15:47:05 +05:30

test_simple_end_to_end.py

[FEATURE] Enhanced Vector Store for Decision Tracking #293

2026-02-11 19:02:33 +05:30

test_sqlite_vec_store.py

feat(vector_store): add scan_vectors enumeration and wire up store mi… (#1264)

2026-08-30 17:31:57 +05:30

test_vector_manager_persistent.py

fix(vector_store): sync qdrant iter_all() with #1316's stall-guard fix

2026-09-02 17:39:42 +05:30

test_vector_store_deepdive.py

Fix/parse and qdrant vector store (#1508)

2026-09-08 15:47:05 +05:30

test_vector_store_parallel.py

Add high-performance VectorStore ingestion and docs

2026-01-19 13:32:16 +05:30

test_vector_store.py

fix: prevent duplicate dimension kwarg crash in create_index

2026-08-23 15:51:25 +05:30

test_weaviate_delete_vectors.py

test(weaviate): cover delete_vectors and erasure integration

2026-09-02 20:45:22 +08:00

test_weaviate_store.py

fix(vector_store): don't treat an empty weaviate page as end of scan

2026-09-02 17:43:52 +05:30