mirror of
https://github.com/semantica-agi/semantica.git
synced 2026-08-29 04:26:20 +00:00
Sameer6305
80de3652cf
Two issues addressed: 1. Plugin-loading useEffect unnecessarily depended on temporalState. After the #830 fix, no shouldLoad predicate reads temporalState, but the effect's dep array still included it, causing extra re-runs on every scrubber update. Removed temporalState from the dep array and the shouldLoad call site. Made temporalState optional in the LazyPluginRegistryEntry shouldLoad context type to match. 2. Regression test imported a local copy of shouldLoad instead of the production predicate. Extracted all three shouldLoad predicates into pluginRegistryPredicates.ts (pure module, no React/DOM dependencies), wired GraphWorkspace.tsx to use the imported functions, and updated the test to import and exercise the real production code via tsx. Verified: introducing the old broken condition causes the test to fail; the correct implementation passes all 7 assertions.
107 lines
4.4 KiB
JavaScript
107 lines
4.4 KiB
JavaScript
/**
|
|
* Regression tests for Issue #830: plugin registry shouldLoad predicates.
|
|
*
|
|
* The original temporal-overlay shouldLoad was:
|
|
* ({ panelState, temporalState }) =>
|
|
* Boolean(panelState["temporal-panel"] || temporalState?.currentTime)
|
|
*
|
|
* This caused an infinite render loop because temporalState.currentTime is
|
|
* non-null from startup (TimelinePanel fires onTimeChange on mount), so the
|
|
* predicate returned true before the panel was ever opened, repeatedly
|
|
* triggering the plugin-loading useEffect during every scrubber update and
|
|
* cancelling in-flight load() calls before they could register the plugin.
|
|
*
|
|
* The fix: each predicate reads only panelState so plugin loading is
|
|
* gated strictly on the user opening the corresponding panel.
|
|
*
|
|
* These tests import the PRODUCTION predicates from pluginRegistryPredicates.ts
|
|
* via tsx so that a future regression in GraphWorkspace.tsx is detected here.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { createRequire } from "node:module";
|
|
|
|
// tsx is available as a Node loader — use createRequire to exercise the
|
|
// TypeScript module from this .mjs file.
|
|
const require = createRequire(import.meta.url);
|
|
|
|
// tsx must be registered before requiring .ts files. The test:plugin-registry
|
|
// script calls this file via `node --import tsx --test`, so tsx is already
|
|
// active in the process when this module runs.
|
|
const {
|
|
explorationEffectsShouldLoad,
|
|
neighborhoodPanelShouldLoad,
|
|
temporalOverlayShouldLoad,
|
|
} = require("../src/workspaces/GraphWorkspace/pluginRegistryPredicates.ts");
|
|
|
|
// ── temporal-overlay ─────────────────────────────────────────────────────────
|
|
|
|
test("temporal-overlay shouldLoad: false when panel is closed and no scrubber time", () => {
|
|
assert.equal(
|
|
temporalOverlayShouldLoad({ panelState: { "temporal-panel": false } }),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("temporal-overlay shouldLoad: false when panel is closed even if scrubber time is set", () => {
|
|
// Before the fix this returned true — TimelinePanel sets currentTime on mount,
|
|
// causing eager loads that continuously reset the cancelled flag and prevented
|
|
// plugin registration.
|
|
assert.equal(
|
|
temporalOverlayShouldLoad({
|
|
panelState: { "temporal-panel": false },
|
|
temporalState: { currentTime: new Date() },
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test("temporal-overlay shouldLoad: true only when the panel is explicitly opened", () => {
|
|
assert.equal(
|
|
temporalOverlayShouldLoad({ panelState: { "temporal-panel": true } }),
|
|
true,
|
|
);
|
|
});
|
|
|
|
test("temporal-overlay shouldLoad: true when panel opened even without a scrubber time", () => {
|
|
assert.equal(
|
|
temporalOverlayShouldLoad({
|
|
panelState: { "temporal-panel": true },
|
|
temporalState: { currentTime: null },
|
|
}),
|
|
true,
|
|
);
|
|
});
|
|
|
|
// ── other entries — confirm they also gate only on panelState ─────────────────
|
|
|
|
test("exploration-effects shouldLoad: gates only on effects-panel state", () => {
|
|
assert.equal(explorationEffectsShouldLoad({ panelState: { "effects-panel": false } }), false);
|
|
assert.equal(explorationEffectsShouldLoad({ panelState: { "effects-panel": true } }), true);
|
|
});
|
|
|
|
test("neighborhood-panel shouldLoad: gates only on neighborhood-panel state", () => {
|
|
assert.equal(neighborhoodPanelShouldLoad({ panelState: { "neighborhood-panel": false } }), false);
|
|
assert.equal(neighborhoodPanelShouldLoad({ panelState: { "neighborhood-panel": true } }), true);
|
|
});
|
|
|
|
test("all three shouldLoad conditions are consistent: none reference temporalState", () => {
|
|
// A predicate that regressed to reading temporalState?.currentTime would
|
|
// return true here even though every panel is closed — detecting the loop bug.
|
|
const nonNullTemporalState = { currentTime: new Date(), activeNodeCount: 6 };
|
|
|
|
assert.equal(
|
|
temporalOverlayShouldLoad({ panelState: { "temporal-panel": false }, temporalState: nonNullTemporalState }),
|
|
false,
|
|
"temporal-overlay must not load when panel is closed, regardless of scrubber time",
|
|
);
|
|
assert.equal(
|
|
explorationEffectsShouldLoad({ panelState: { "effects-panel": false }, temporalState: nonNullTemporalState }),
|
|
false,
|
|
);
|
|
assert.equal(
|
|
neighborhoodPanelShouldLoad({ panelState: { "neighborhood-panel": false }, temporalState: nonNullTemporalState }),
|
|
false,
|
|
);
|
|
});
|