mirror of
https://github.com/semantica-agi/semantica.git
synced 2026-09-12 04:01:35 +00:00
1928f80104
Addresses all 7 findings from the automated review on this PR: - ontology: OntologyEngine() has no store configured, so list_concepts/list_vocabularies always raise ProcessingError; construct it with a TripletStore - ontology: ValidationResult's field is `valid`, not `is_valid` - change: state_at()["nodes"] is a list of dicts, so set(...) on it raises TypeError: unhashable type: 'dict' — diff by node id instead - provenance/change: storage_path is passed to sqlite3.connect() unexpanded, so a literal "~/.semantica/prov.db" fails to open — expanduser + mkdir - change/query: load_from_file() checks the literal path, so "~/..." never resolves and the graph loads empty — expanduser before calling - query: QueryEngine.execute_query requires an object exposing execute_sparql(); the TripletStore wrapper doesn't expose that, only the raw backend (e.g. OxigraphStore) does - query: the Cypher example constructed Neo4jStore but never called execute_query() Co-Authored-By: gyro <zhuffwct@gmail.com> Co-Authored-By: KaifAhmad1 <mohammadk78600@gmail.com>