mirror of
https://github.com/semantica-agi/semantica.git
synced 2026-09-09 04:00:52 +00:00
BingEdward
c449209168
Route `semantica mcp call` and `semantica mcp list-tools` through the canonical `semantica_mcp.mcp.server` packaged module instead of the nonexistent `MCPSession` import. Previously, `semantica mcp call` imported `MCPSession` from `semantica_mcp.mcp.session`, which never defined it, causing every call to fail with "MCP module not available". Meanwhile, `semantica mcp list-tools` inspected `semantica_mcp.mcp.tools.__all__`, which evaluated to `["TOOL_DEFINITIONS"]` and printed a single tool named "TOOL_DEFINITIONS". Key changes: - Implement `semantica_mcp.mcp.server.call_tool(name, arguments)` as the shared in-process entry point used by both the CLI and the JSON-RPC `tools/call` handler, ensuring both surfaces expose identical tools. - Add `UnknownToolError` to distinguish missing tools (JSON-RPC -32601) from handler-level `KeyError` exceptions (JSON-RPC -32603). - Update `semantica mcp list-tools` to source tool names directly from `TOOL_DEFINITIONS` in `semantica_mcp.mcp.tools`. - Validate `--args` payloads and reject non-object JSON inputs (arrays, primitives, null) with a clean `ClickException`. - Update `tests/test_mcp_stdio_roundtrip.py` to spawn `semantica_mcp.mcp` instead of the pre-relocation `mcp` module, restoring clean stdio framing tests. Fixes #1355
65 lines
2.4 KiB
Python
65 lines
2.4 KiB
Python
"""Tests for the shared in-process tool entry point (issue #1355).
|
|
|
|
``semantica_mcp.mcp.server.call_tool`` is the dispatch used by both the
|
|
JSON-RPC ``tools/call`` handler and the ``semantica mcp call`` CLI command,
|
|
so the two surfaces cannot expose different tool sets.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
import unittest
|
|
from unittest.mock import patch
|
|
|
|
sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), "..")))
|
|
|
|
from semantica_mcp.mcp import server
|
|
from semantica_mcp.mcp.server import UnknownToolError, _handle_tools_call, call_tool
|
|
|
|
|
|
class TestCallTool(unittest.TestCase):
|
|
|
|
def test_known_tool_dispatches_to_handler(self):
|
|
# Empty args hit extract_entities' own validation before any heavy
|
|
# imports, which is enough to prove dispatch reached the handler.
|
|
result = call_tool("extract_entities", {})
|
|
self.assertEqual(result["error"], "text is required")
|
|
|
|
def test_unknown_tool_raises_unknown_tool_error(self):
|
|
with self.assertRaises(UnknownToolError):
|
|
call_tool("no_such_tool", {})
|
|
|
|
def test_unknown_tool_error_is_not_a_key_error(self):
|
|
"""A handler's own KeyError (missing required arg) must remain
|
|
distinguishable from an unknown tool name."""
|
|
self.assertFalse(issubclass(UnknownToolError, KeyError))
|
|
|
|
|
|
class TestToolsCallDispatch(unittest.TestCase):
|
|
|
|
@staticmethod
|
|
def _tools_call(name, arguments):
|
|
return _handle_tools_call(1, {"name": name, "arguments": arguments})
|
|
|
|
def test_unknown_tool_returns_method_not_found(self):
|
|
response = self._tools_call("no_such_tool", {})
|
|
self.assertEqual(response["error"]["code"], -32601)
|
|
self.assertEqual(response["error"]["message"], "Unknown tool: no_such_tool")
|
|
|
|
def test_handler_key_error_is_internal_error_not_unknown_tool(self):
|
|
def _boom(args):
|
|
raise KeyError("category")
|
|
|
|
fake = {"name": "boom", "description": "", "inputSchema": {}, "_handler": _boom}
|
|
with patch.dict(server._TOOL_INDEX, {"boom": fake}):
|
|
response = self._tools_call("boom", {})
|
|
self.assertEqual(response["error"]["code"], -32603)
|
|
|
|
def test_known_tool_returns_result_content(self):
|
|
response = self._tools_call("extract_entities", {})
|
|
self.assertIn("content", response["result"])
|
|
self.assertTrue(response["result"]["isError"])
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|