ci(windows): make windows-coverage temporarily non-blocking

Other PRs are blocked by Windows ACP half-close tests timing out. Keep the
coverage job running for signal, but remove it from all-checks-passed.needs
until the Windows skip fix is validated.
This commit is contained in:
Chinesezjc
2026-08-25 17:02:16 +08:00
parent eea3c132ff
commit ac2f00070e
2 changed files with 5 additions and 4 deletions
+1 -1
View File
@@ -568,7 +568,7 @@ jobs:
&& github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.user.login != 'dependabot[bot]'
&& fromJSON('["self-hosted", "linux", "x64", "vm-backup"]') && fromJSON('["self-hosted", "linux", "x64", "vm-backup"]')
|| 'ubuntu-latest' }} || 'ubuntu-latest' }}
needs: [node-24, node-24-coverage, node-24-consumers, node-compat, python-sdk, python-runtime, windows, windows-build, windows-coverage, windows-native-tests] needs: [node-24, node-24-coverage, node-24-consumers, node-compat, python-sdk, python-runtime, windows, windows-build, windows-native-tests]
if: always() && github.event_name == 'pull_request' if: always() && github.event_name == 'pull_request'
steps: steps:
- name: Fail if any needed job did not succeed - name: Fail if any needed job did not succeed
+4 -3
View File
@@ -129,11 +129,12 @@ describe('CI workflow', () => {
expect(serialWindows['runs-on']).toEqual(['self-hosted', 'dsh-win-ci', 'windows']) expect(serialWindows['runs-on']).toEqual(['self-hosted', 'dsh-win-ci', 'windows'])
expect(serialWindows.name).toBe('serial / windows (self-hosted standby)') expect(serialWindows.name).toBe('serial / windows (self-hosted standby)')
// Aggregate: Wine and the three required split native jobs are needed; // Aggregate: Wine and the required split native jobs are needed;
// observational stays out of the verdict. // windows-coverage is temporarily non-blocking while Windows ACP
// half-close tests are stabilized; observational stays out too.
expect(aggregate.needs).toContain('windows') expect(aggregate.needs).toContain('windows')
expect(aggregate.needs).toContain('windows-build') expect(aggregate.needs).toContain('windows-build')
expect(aggregate.needs).toContain('windows-coverage') expect(aggregate.needs).not.toContain('windows-coverage')
expect(aggregate.needs).toContain('windows-native-tests') expect(aggregate.needs).toContain('windows-native-tests')
expect(aggregate.needs).not.toContain('windows-observational') expect(aggregate.needs).not.toContain('windows-observational')
expect(aggregate.needs).not.toContain('serial-windows') expect(aggregate.needs).not.toContain('serial-windows')