mirror of
https://github.com/deepseek-ai/deepseek-harness.git
synced 2026-09-06 07:11:59 +00:00
Yichen Jiang
c62d6f3a44
Review asked why this is a plugin and why it exports so much. The design note this branch shipped answered the second question itself — "a pure resolution function plus an installation function" — and the code drifted to seventeen exports and a Cordis plugin nobody approved or mounted. The plugin is gone. Transport policy has one answer per process: nothing to swap, and no scope narrower than the process to give one. Its `Config` was also the only supplier of a configuration branch, so resolution now reads the environment and nothing else — `mode`, the config-sourced fields, and the `config` policy source were unreachable the moment the plugin left. Four exports nothing outside the package used are internal again, and `currentProxyPolicy` answers with the direct policy instead of `undefined`, so `DIRECT_POLICY` no longer needs a public face. Nine functions remain, one per way a caller can need the policy; two is not reachable with six consumer seams. The package moves to `util/`. The note claimed a dependency on `undici` disqualified it from that group; the charter governs harness dependencies, not external ones, and the process note that says so predates this branch. The real blocker was the harness dependency: resolution needed one method of `LaunchEnvironmentSnapshot`, so it names a structural `EnvLookup` and the launcher passes its snapshot unchanged. `net/` is dissolved. Dropping the group's line from the repository layout also returns `AGENTS.md` to its original ceiling, so the raise the merge needed is reverted.
64 lines
3.0 KiB
TypeScript
64 lines
3.0 KiB
TypeScript
/**
|
|
* Remove the machine's proxy configuration from every Vitest process.
|
|
*
|
|
* A developer's Clash and a CI runner's squid both export `HTTP_PROXY` and its siblings. Now that
|
|
* the harness honors them, an ambient value silently decides test outcomes: a request meant for a
|
|
* local fixture server is sent to a proxy that cannot resolve the fixture's hostname, and the
|
|
* proxy's error page is recorded as the expected output. The same value also stands in for "what
|
|
* the user exported" in any assertion about inherited proxy names.
|
|
*
|
|
* Clearing here gives every suite one known starting environment, so a test that needs a proxy sets
|
|
* exactly the names it means to exercise. Suites that spawn a real `dsh` still clear the child's
|
|
* environment themselves — they must hold whether or not a Vitest setup ran.
|
|
*
|
|
* One name resists this: `NODE_USE_ENV_PROXY`. Node samples the proxy environment when the process
|
|
* starts, so deleting the variable from a setup file cannot unbind the built-in `fetch` it already
|
|
* configured. A shell that exports it must unset it before running the suite. The names a proxy
|
|
* application or a corporate profile actually exports — the eight below — are fully handled, because
|
|
* only this repository's own resolver reads them and it runs after this.
|
|
*
|
|
* Real-API e2e is cleared too. Before proxy support existed every request connected directly and
|
|
* that suite passed, so a direct connection is the environment it is known to work in; leaving the
|
|
* ambient proxy in place would newly stake it on the proxy reaching the provider.
|
|
* @module
|
|
*/
|
|
|
|
import { globSync } from 'node:fs'
|
|
import { resolve } from 'node:path'
|
|
import { PROXY_ENV_NAMES } from '../packages/util/http-proxy/src/policy.ts'
|
|
|
|
/** The flag a Node process reads before honoring the names above; ambient in the same way. */
|
|
const NODE_PROXY_FLAG = 'NODE_USE_ENV_PROXY'
|
|
|
|
/** This module's path as a `setupFiles` entry, so its own wiring test names it once. */
|
|
export const TEST_PROXY_SETUP_FILE = './scripts/test-proxy-environment.ts'
|
|
|
|
/**
|
|
* Every Vitest configuration in the repository, discovered rather than listed: the web suites carry
|
|
* no `setupFiles` today, and a hand-written list would let one of them gain a setup without gaining
|
|
* this one. The wiring test asserts only over the configurations that declare a setup at all.
|
|
*
|
|
* @returns repository-relative config paths, sorted.
|
|
*/
|
|
export function vitestConfigFiles(): string[] {
|
|
return globSync('vitest*.ts', { cwd: resolve(import.meta.dirname, '..') }).sort()
|
|
}
|
|
|
|
/**
|
|
* Delete every proxy name from one environment.
|
|
*
|
|
* @param env - the environment to clear.
|
|
* @returns the names that carried a value, in the order checked.
|
|
*/
|
|
export function clearAmbientProxyEnv(env: NodeJS.ProcessEnv): string[] {
|
|
const cleared: string[] = []
|
|
for (const name of [...PROXY_ENV_NAMES, NODE_PROXY_FLAG]) {
|
|
if (env[name] === undefined) continue
|
|
cleared.push(name)
|
|
Reflect.deleteProperty(env, name)
|
|
}
|
|
return cleared
|
|
}
|
|
|
|
clearAmbientProxyEnv(process.env)
|