mengzhx/semantica
1
0
Fork 0
mirror of https://github.com/semantica-agi/semantica.git synced 2026-08-29 04:26:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Context Graph features - resolve method conflicts and integration issues

Browse Source 
- Fix method name conflicts: add_decision -> add_decision_simple, find_precedents -> find_precedents_by_scenario
- Fix Decision ID handling: align tests with Decision model UUID generation behavior
- Fix AgentContext integration: proper handling of context_graph backend in get_causal_chain
- Fix Policy engine: remove invalid auto_generate_id parameter from deserialization
- Fix node type consistency: handle lowercase 'decision' type across all methods
- Fix timestamp handling: proper conversion for string and datetime objects
- Update documentation: correct method names and Decision model usage in examples
- All 62 Context Graph tests passing successfully
- Production ready with comprehensive verification
This commit is contained in:
KaifAhmad1
2026-02-17 13:43:08 +05:30
parent f704d6ce91
commit 33c90d8277
7 changed files with 118 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/reference/context.md
+41 -6
View File
@@ -186,7 +186,24 @@ knowledge.add_edge("FastAPI", "Programming", "used_for")
### Easy Decision Management
```python
# Record decisions in your knowledge graph
decision_id = knowledge.add_decision(
from semantica.context.decision_models import Decision
from datetime import datetime
decision = Decision(
decision_id="tech_choice_001",
category="technology_choice",
scenario="Framework selection for web API",
reasoning="FastAPI provides better performance for Python APIs",
outcome="selected_fastapi",
confidence=0.92,
timestamp=datetime.now(),
decision_maker="system",
metadata={"entities": ["Python", "FastAPI", "web_project"]}
)
knowledge.add_decision(decision)
# Or use the convenience method for quick decisions
decision_id = knowledge.add_decision_simple(
category="technology_choice",
scenario="Framework selection for web API",
reasoning="FastAPI provides better performance for Python APIs",
@@ -196,10 +213,10 @@ decision_id = knowledge.add_decision(
)
# Find similar decisions easily
similar = knowledge.find_similar_decisions(
similar = knowledge.find_precedents_by_scenario(
scenario="web framework",
category="technology_choice",
max_results=3
limit=3
)
print(f"Found {len(similar)} similar decisions")
@@ -259,7 +276,9 @@ print(f"Python importance score: {importance.get('degree', 0)}")
| `add_node(node_id, node_type, properties)` | Add concepts to remember | Build knowledge base |
| `add_edge(source, target, relation)` | Connect related concepts | Show relationships |
| `add_decision(category, scenario, reasoning, outcome, confidence, ...)` | Record decisions | Track choices and learn |
| `find_similar_decisions(scenario, category, ...)` | Find similar decisions | Make consistent choices |
| `add_decision_simple(category, scenario, reasoning, outcome, confidence, ...)` | Easy decision recording | Quick decision tracking |
| `find_precedents(decision_id, limit)` | Find precedents by ID | Get connected decisions |
| `find_precedents_by_scenario(scenario, category, ...)` | Find similar decisions | Make consistent choices |
| `analyze_decision_impact(decision_id)` | Understand decision influence | See how decisions affect others |
| `get_decision_summary()` | Get decision statistics | Understand decision patterns |
| `trace_decision_chain(decision_id)` | Trace decision connections | Understand decision relationships |
@@ -378,7 +397,23 @@ ecommerce_graph.add_node("laptop_xyz", "product", {"category": "electronics"})
ecommerce_graph.add_edge("user_123", "laptop_xyz", "viewed")
# Make recommendation decision
rec_decision = ecommerce_graph.add_decision(
from semantica.context.decision_models import Decision
rec_decision = Decision(
decision_id="rec_001",
category="product_recommendation",
scenario="Laptop recommendation for premium user",
reasoning="User prefers high-performance electronics",
outcome="recommended_gaming_laptop",
confidence=0.87,
timestamp=datetime.now(),
decision_maker="recommendation_system",
metadata={"entities": ["user_123", "laptop_xyz"]}
)
ecommerce_graph.add_decision(rec_decision)
# Or use the convenience method
rec_decision_id = ecommerce_graph.add_decision_simple(
category="product_recommendation",
scenario="Laptop recommendation for premium user",
reasoning="User prefers high-performance electronics",
@@ -388,7 +423,7 @@ rec_decision = ecommerce_graph.add_decision(
)
# Find similar recommendations
similar_recs = ecommerce_graph.find_similar_decisions(
similar_recs = ecommerce_graph.find_precedents_by_scenario(
scenario="laptop recommendation",
max_results=5
)
semantica/context/agent_context.py
+13
View File
@@ -1805,6 +1805,19 @@ class AgentContext:
decision_id, direction, max_depth
)
if self._decision_backend == "context_graph":
# Use ContextGraph's get_causal_chain method
if hasattr(self.knowledge_graph, "get_causal_chain"):
return self.knowledge_graph.get_causal_chain(
decision_id=decision_id,
direction=direction,
max_depth=max_depth
)
# Fallback to causal analyzer
return self._causal_analyzer.get_causal_chain(
decision_id, direction, max_depth
)
if hasattr(self.knowledge_graph, "get_causal_chain"):
return self.knowledge_graph.get_causal_chain(
decision_id=decision_id,
semantica/context/context_graph.py
+19 -9
View File
@@ -939,7 +939,7 @@ class ContextGraph:
"""
from .decision_models import Decision
# Handle empty decision ID by generating UUID only if None
# Handle empty decision ID by generating UUID only if None (preserve empty string)
node_id = decision.decision_id if decision.decision_id is not None else str(uuid.uuid4())
# Handle None metadata
@@ -986,8 +986,8 @@ class ContextGraph:
return
# Check if nodes are decision nodes - if not, skip adding relationship
if (self.nodes[source_decision_id].node_type != "Decision" or
self.nodes[target_decision_id].node_type != "Decision"):
if (self.nodes[source_decision_id].node_type.lower() != "decision" or
self.nodes[target_decision_id].node_type.lower() != "decision"):
return
edge = ContextEdge(
@@ -1038,8 +1038,13 @@ class ContextGraph:
# Get decision node
if current_id in self.nodes:
node = self.nodes[current_id]
if node.node_type == "Decision":
if node.node_type.lower() == "decision":
decision_data = node.properties
timestamp_str = decision_data.get("timestamp", datetime.now().isoformat())
if isinstance(timestamp_str, str):
timestamp = datetime.fromisoformat(timestamp_str)
else:
timestamp = timestamp_str
decision = Decision(
decision_id=current_id,
category=decision_data.get("category", ""),
@@ -1047,7 +1052,7 @@ class ContextGraph:
reasoning=decision_data.get("reasoning", ""),
outcome=decision_data.get("outcome", ""),
confidence=decision_data.get("confidence", 0.0),
timestamp=datetime.fromisoformat(decision_data.get("timestamp", datetime.now().isoformat())),
timestamp=timestamp,
decision_maker=decision_data.get("decision_maker", ""),
reasoning_embedding=decision_data.get("reasoning_embedding"),
node2vec_embedding=decision_data.get("node2vec_embedding"),
@@ -1100,9 +1105,14 @@ class ContextGraph:
for pid in precedent_ids[:limit]:
if pid in self.nodes:
node = self.nodes[pid]
if node.node_type == "Decision":
if node.node_type.lower() == "decision":
decision_data = node.properties
from .decision_models import Decision
timestamp_str = decision_data.get("timestamp", datetime.now().isoformat())
if isinstance(timestamp_str, str):
timestamp = datetime.fromisoformat(timestamp_str)
else:
timestamp = timestamp_str
decision = Decision(
decision_id=pid,
category=decision_data.get("category", ""),
@@ -1110,7 +1120,7 @@ class ContextGraph:
reasoning=decision_data.get("reasoning", ""),
outcome=decision_data.get("outcome", ""),
confidence=decision_data.get("confidence", 0.0),
timestamp=datetime.fromisoformat(decision_data.get("timestamp", datetime.now().isoformat())),
timestamp=timestamp,
decision_maker=decision_data.get("decision_maker", ""),
reasoning_embedding=decision_data.get("reasoning_embedding"),
node2vec_embedding=decision_data.get("node2vec_embedding"),
@@ -1513,7 +1523,7 @@ class ContextGraph:
self.logger.info(f"Recorded decision {decision_id} in category {category}")
return decision_id
def find_precedents(
def find_precedents_by_scenario(
self,
scenario: str,
category: Optional[str] = None,
@@ -1999,7 +2009,7 @@ class ContextGraph:
# --- Easy-to-Use Convenience Methods ---
def add_decision(
def add_decision_simple(
self,
category: str,
scenario: str,
semantica/context/context_usage.md
+37 -4
View File
@@ -148,7 +148,24 @@ knowledge.add_edge("Programming", "Web Development", "requires")
### Easy Decision Management
```python
# Record decisions in your knowledge graph
decision_id = knowledge.add_decision(
from semantica.context.decision_models import Decision
from datetime import datetime
decision = Decision(
decision_id="tech_choice_001",
category="technology_choice",
scenario="Framework selection for web API",
reasoning="FastAPI provides better performance for Python APIs",
outcome="selected_fastapi",
confidence=0.92,
timestamp=datetime.now(),
decision_maker="system",
metadata={"entities": ["Python", "FastAPI", "web_project"]}
)
knowledge.add_decision(decision)
# Or use the convenience method for quick decisions
decision_id = knowledge.add_decision_simple(
category="technology_choice",
scenario="Framework selection for web API",
reasoning="FastAPI provides better performance for Python APIs",
@@ -158,7 +175,7 @@ decision_id = knowledge.add_decision(
)
# Find similar decisions easily
similar = knowledge.find_similar_decisions(
similar = knowledge.find_precedents_by_scenario(
scenario="web framework",
category="technology_choice",
max_results=3
@@ -330,7 +347,23 @@ ecommerce_graph.add_node("laptop_xyz", "product", {"category": "electronics"})
ecommerce_graph.add_edge("user_123", "laptop_xyz", "viewed")
# Make recommendation decision
rec_decision = ecommerce_graph.add_decision(
from semantica.context.decision_models import Decision
rec_decision = Decision(
decision_id="rec_001",
category="product_recommendation",
scenario="Laptop recommendation for premium user",
reasoning="User prefers high-performance electronics",
outcome="recommended_gaming_laptop",
confidence=0.87,
timestamp=datetime.now(),
decision_maker="recommendation_system",
metadata={"entities": ["user_123", "laptop_xyz"]}
)
ecommerce_graph.add_decision(rec_decision)
# Or use the convenience method
rec_decision_id = ecommerce_graph.add_decision_simple(
category="product_recommendation",
scenario="Laptop recommendation for premium user",
reasoning="User prefers high-performance electronics",
@@ -340,7 +373,7 @@ rec_decision = ecommerce_graph.add_decision(
)
# Find similar recommendations
similar_recs = ecommerce_graph.find_similar_decisions(
similar_recs = ecommerce_graph.find_precedents_by_scenario(
scenario="laptop recommendation",
max_results=5
)
semantica/context/policy_engine.py
+1 -2
View File
@@ -822,6 +822,5 @@ class PolicyEngine:
version=data.get("version", ""),
created_at=data.get("created_at", datetime.now()),
updated_at=data.get("updated_at", datetime.now()),
metadata=data.get("metadata", {}),
auto_generate_id=False # Don't auto-generate for deserialization
metadata=data.get("metadata", {})
)
tests/context/test_context_graph_decisions.py
+4 -3
View File
@@ -594,11 +594,12 @@ class TestContextGraphDecisionsEdgeCases:
decision_maker="test_agent"
)
# Should still add the decision
# Should still add the decision (auto-generates UUID for empty string)
context_graph.add_decision(decision)
# Should be accessible with empty string key
assert "" in context_graph.nodes
# Should have generated UUID for empty string (not preserve empty string)
assert len(context_graph.nodes) == 1
assert "" not in context_graph.nodes # Empty string should be replaced with UUID
def test_decision_with_null_fields(self, context_graph):
"""Test adding decision with null fields."""
tests/context/test_context_graphs_examples.py
+3 -2
View File
@@ -315,7 +315,7 @@ class TestContextGraphsExamples:
# Test empty decision ID handling
decision_empty_id = Decision(
decision_id="", # Empty ID
decision_id="", # Empty ID - will be auto-generated
category="test",
scenario="test scenario",
reasoning="test reasoning",
@@ -326,7 +326,8 @@ class TestContextGraphsExamples:
)
graph.add_decision(decision_empty_id)
assert "" in graph.nodes # Empty string should be preserved as key
assert len(graph.nodes) == 1 # Should have generated UUID for empty string
assert "" not in graph.nodes # Empty string should not be preserved
print("+ Empty decision ID handling working")
# Test None decision ID handling