mengzhx/semantica
1
0
Fork 0
mirror of https://github.com/semantica-agi/semantica.git synced 2026-08-29 04:26:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(vector-store): guard save()/load() indexer access for persistent backends

Browse Source 
self.indexer is only set for backend="inmemory", so save()/load() still
raised AttributeError for persistent backends (faiss, qdrant, etc.) even
after this PR's getattr() guards on self.vectors/self.metadata, since the
unguarded `self.indexer` access happened first. Guard it the same way and
delegate to the backend store's native save_index/load_index (currently
only FAISSStore implements these) so persistent-backend saves actually
persist instead of silently no-oping.
This commit is contained in:
KaifAhmad1
2026-08-08 11:50:09 +05:30
parent f75469f472
commit 916d3974e3
1 changed files with 19 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
semantica/vector_store/vector_store.py
+19 -9
View File
@@ -559,12 +559,15 @@ class VectorStore:
import pickle
os.makedirs(path, exist_ok=True)
# Save metadata and vectors (generic fallback)
# Ideally, backends like FAISS have their own save methods
if hasattr(self.indexer, "save_index"):
self.indexer.save_index(os.path.join(path, "index.bin"))
indexer = getattr(self, "indexer", None)
if indexer is not None and hasattr(indexer, "save_index"):
indexer.save_index(os.path.join(path, "index.bin"))
elif self._backend_store is not None and hasattr(self._backend_store, "save_index"):
self._backend_store.save_index(os.path.join(path, "index.bin"))
# Save Python-level data
data = {
"vectors": getattr(self, "vectors", {}),
@@ -604,14 +607,21 @@ class VectorStore:
self.dimension = data.get("dimension", 768)
# Restore backend-specific index
if hasattr(self.indexer, "load_index"):
index_path = os.path.join(path, "index.bin")
indexer = getattr(self, "indexer", None)
index_path = os.path.join(path, "index.bin")
if indexer is not None and hasattr(indexer, "load_index"):
if os.path.exists(index_path):
self.indexer.load_index(index_path)
indexer.load_index(index_path)
else:
# Rebuild if index file missing but vectors present
self.indexer.create_index(list(self.vectors.values()), list(self.vectors.keys()))
indexer.create_index(list(self.vectors.values()), list(self.vectors.keys()))
elif (
self._backend_store is not None
and hasattr(self._backend_store, "load_index")
and os.path.exists(index_path)
):
self._backend_store.load_index(index_path)
self.logger.info(f"Loaded vector store from {path}")
def search(self, query: str, limit: int = 10, **options) -> List[Dict[str, Any]]: